Skip to content

Modernize Blob constructor a tiny bit#125

Open
annevk wants to merge 1 commit into
mainfrom
annevk/blob-constructor
Open

Modernize Blob constructor a tiny bit#125
annevk wants to merge 1 commit into
mainfrom
annevk/blob-constructor

Conversation

@annevk

@annevk annevk commented Apr 5, 2019

Copy link
Copy Markdown
Member

All implementations do something different for new Blob(undefined, { type: "x/x" }). Let's do something simple.

Fixes #54.


Preview | Diff

@mkruisselbrink mkruisselbrink left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me. Do you happen to have tests for this as well?

@annevk

annevk commented Apr 9, 2019

Copy link
Copy Markdown
Member Author

I don't. I wanted to fix the general type setup, but I keep running out of time.

@marcoscaceres

Copy link
Copy Markdown
Member

need to close and reopen to trigger new travis

@marcoscaceres

Copy link
Copy Markdown
Member

@annevk, could you please fix the merge conflicts? The constructor can now be updated to new syntax.

@annevk

annevk commented Apr 14, 2020

Copy link
Copy Markdown
Member Author

Once there are sufficient tests I'm happy to address the remainder (including filing bugs).

@marcoscaceres

Copy link
Copy Markdown
Member

ok, no probs. Was worried about bit rot. How about just getting it to a good state and we just don't merge until there are tests? The only thing I was unsure about was the merge conflict with the algorithm, the IDL seems like a quick fix.

All implementations do something different for new Blob(undefined, { type: "x/x" }). Let's do something simple.

Fixes #54.
@annevk annevk force-pushed the annevk/blob-constructor branch from abb6af3 to 07dc190 Compare April 14, 2020 14:40
Base automatically changed from master to main January 21, 2021 23:46
@marcoscaceres

Copy link
Copy Markdown
Member

@annevk, just saw this was still pending. Should this be updated and merged?

@annevk

annevk commented May 26, 2024

Copy link
Copy Markdown
Member Author

@wisniewskit did you end up doing whatwg/mimesniff#189 (comment) in Gecko? Maybe I should take some time to make the specification say that to try to move this along.

@saschanaz

saschanaz commented May 26, 2024

Copy link
Copy Markdown
Member

Looks like the plan is to change our behavior first and see whether it's web compatible, before changing WPT: https://phabricator.services.mozilla.com/D208848

@wisniewskit

wisniewskit commented May 26, 2024

Copy link
Copy Markdown

@annevk, I haven't yet landed the patches for Gecko to try that, as I'm still figuring out which test cases in our own codebase fail, and how to deal with them. But it's not looking intractable, so hopefully we can land it sometime soon and get data on whether there's any obvious fallout on sites. (Of course it would be faster and fairer if others also did the same, so I welcome anyone willing to help push other vendors along as well!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

What does it mean to invoke the Blob constructor with zero parameters?

6 participants